Port mutable test to delta-tree; Remove mutable test by JaySon-Huang · Pull Request #3483 · pingcap/tiflash

JaySon-Huang · 2021-11-19T10:32:24Z

What problem does this PR solve?

Issue Number: a part of #3481, close #2717

Problem Summary: Remove outdated mutable-test files. Getting ready for removing *MergeTree family from TiFlash codebase.

What is changed and how it works?

What's Changed:

Remove tests/mutable-test/txn_mock/snapshot.test since it is duplicated with tests/delta-merge-test/raft/snapshot.test
Remove tests/mutable-test/txn_mock/region_merge.test since it is duplicated with tests/delta-merge-test/raft/region_merge.test
Remove tests/mutable-test/txn_mock/compact.test since it mainly focus on compaction MergeTree parts
Port other test cases into delta-merge-test
Remove mutable-test from CI
Remove related files for mutable-test

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch:

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Release note

None

Signed-off-by: JaySon-Huang <tshent@qq.com>

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

ti-chi-bot · 2021-11-19T10:32:24Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

JaySon-Huang · 2021-11-19T10:39:03Z

/run-all-tests

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

sre-bot · 2021-11-19T10:52:16Z

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/120/cobertura/
(Coverage detail url is limited office network access)

lines: 35.5% (43333 out of 122168)
branches: 5.4% (65912 out of 1220015)

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

JaySon-Huang · 2021-11-19T10:55:05Z

/run-all-tests

sre-bot · 2021-11-19T11:08:34Z

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/121/cobertura/
(Coverage detail url is limited office network access)

lines: 35.5% (43337 out of 122168)
branches: 5.4% (65923 out of 1220015)

solotzg · 2021-11-19T15:18:24Z

lgtm

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

JaySon-Huang · 2021-11-20T02:41:14Z

/run-all-tests

sre-bot · 2021-11-20T02:54:42Z

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/122/cobertura/
(Coverage detail url is limited office network access)

lines: 35.5% (43337 out of 122168)
branches: 5.4% (65906 out of 1220015)

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

JaySon-Huang · 2021-11-23T06:07:15Z

/run-all-tests

sre-bot · 2021-11-23T06:21:20Z

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/131/cobertura/
(Coverage detail url is limited office network access)

lines: 35.5% (43334 out of 122168)
branches: 5.4% (65911 out of 1220015)

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

JaySon-Huang · 2021-11-23T06:59:31Z

tests/delta-merge-test/query/data_type/decimal/cast.test

->> select i + f + d from test
-┌─plus(plus(i, f), d)─┐
-│                -0.5 │
-└─────────────────────┘
-
->> alter table test add column d2 decimal(1, 1) default 0.050000001
-


This has been moved to ut "ConvertColumnTypeTest.GetDefaultValue"

JaySon-Huang · 2021-11-23T07:00:17Z

/run-all-tests

sre-bot · 2021-11-23T07:46:21Z

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/132/cobertura/
(Coverage detail url is limited office network access)

lines: 35.6% (43459 out of 122207)
branches: 5.4% (66040 out of 1220255)

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

JaySon-Huang · 2021-11-24T07:18:49Z

/run-integration-test

JaySon-Huang · 2021-11-24T07:21:06Z

/rebuild

purelind · 2021-11-24T07:31:51Z

/rebuild

JaySon-Huang · 2021-11-25T11:55:49Z

/merge

ti-chi-bot · 2021-11-25T11:55:50Z

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2021-11-25T11:55:55Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: f37459f

sre-bot · 2021-11-25T12:35:27Z

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/153/cobertura/
(Coverage detail url is limited office network access)

lines: 35.6% (43453 out of 122207)
branches: 5.4% (66026 out of 1220255)

fuzhe1989 · 2021-11-25T15:03:42Z

/merge

ti-chi-bot · 2021-11-25T15:03:43Z

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

sre-bot · 2021-11-25T16:03:34Z

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/162/cobertura/
(Coverage detail url is limited office network access)

lines: 35.6% (43457 out of 122207)
branches: 5.4% (66027 out of 1220255)

JaySon-Huang and others added 8 commits November 19, 2021 18:25

Move the decimal/mydatetime tests to dt

5d47dee

Signed-off-by: JaySon-Huang <tshent@qq.com>

Move txn_mock to dt

0e53a9d

Signed-off-by: JaySon-Huang <tshent@qq.com>

Disable creating TMT

db0ad27

Signed-off-by: JaySon-Huang <tshent@qq.com>

Try fix some ported tests

e897897

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

Fix snapshot_no_overlap

a5af0d8

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

Remove duplicated test file

d520ff8

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

Remove useless file

d71e760

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

Mark decimal test for ut instead later

a31549e

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 19, 2021

Format files

ec10710

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

Remove mutable-test from CI

ac301a5

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

Remove mutable-test scripts

6c5aa94

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 19, 2021

JaySon-Huang changed the title ~~[WIP] Port mutable test to delta-tree; Remove mutable test~~ Port mutable test to delta-tree; Remove mutable test Nov 19, 2021

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2021

JaySon-Huang requested review from fuzhe1989 and solotzg November 19, 2021 10:55

JaySon-Huang added the type/code-quality-improvement PR that can improve the code quality label Nov 19, 2021

Fix test for engine = log

dd3754f

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

JaySon-Huang added 2 commits November 22, 2021 11:58

Fix default decimal

4b4b736

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

Foramt

a6baa0c

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

JaySon-Huang self-assigned this Nov 23, 2021

Add ut for decimal default value

9fa91f4

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

JaySon-Huang commented Nov 23, 2021

View reviewed changes

Merge branch 'master' into remove_mutable_test

cc85223

fuzhe1989 approved these changes Nov 23, 2021

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2021

try debug

235311e

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>

Merge branch 'master' into remove_mutable_test

f37459f

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2021

Merge branch 'master' into remove_mutable_test

099ec39

Merge branch 'master' into remove_mutable_test

37522ee

ti-chi-bot merged commit fb1e127 into pingcap:master Nov 25, 2021

JaySon-Huang deleted the remove_mutable_test branch November 25, 2021 17:34

Conversation

JaySon-Huang commented Nov 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Related changes

Check List

Release note

Uh oh!

ti-chi-bot commented Nov 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JaySon-Huang commented Nov 19, 2021

Uh oh!

sre-bot commented Nov 19, 2021

Uh oh!

JaySon-Huang commented Nov 19, 2021

Uh oh!

sre-bot commented Nov 19, 2021

Uh oh!

solotzg commented Nov 19, 2021

Uh oh!

JaySon-Huang commented Nov 20, 2021

Uh oh!

sre-bot commented Nov 20, 2021

Uh oh!

JaySon-Huang commented Nov 23, 2021

Uh oh!

sre-bot commented Nov 23, 2021

Uh oh!

JaySon-Huang Nov 23, 2021

Choose a reason for hiding this comment

Uh oh!

JaySon-Huang commented Nov 23, 2021

Uh oh!

sre-bot commented Nov 23, 2021

Uh oh!

JaySon-Huang commented Nov 24, 2021

Uh oh!

JaySon-Huang commented Nov 24, 2021

Uh oh!

purelind commented Nov 24, 2021

Uh oh!

JaySon-Huang commented Nov 25, 2021

Uh oh!

ti-chi-bot commented Nov 25, 2021

Uh oh!

ti-chi-bot commented Nov 25, 2021

Uh oh!

sre-bot commented Nov 25, 2021

Uh oh!

fuzhe1989 commented Nov 25, 2021

Uh oh!

ti-chi-bot commented Nov 25, 2021

Uh oh!

sre-bot commented Nov 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JaySon-Huang commented Nov 19, 2021 •

edited

Loading

ti-chi-bot commented Nov 19, 2021 •

edited

Loading