Skip to content

Add a script using fio test seq-write/rand-write#3472

Merged
ti-chi-bot merged 3 commits intopingcap:masterfrom
jiaqizho:add-a-fio-test-for-ps
Nov 18, 2021
Merged

Add a script using fio test seq-write/rand-write#3472
ti-chi-bot merged 3 commits intopingcap:masterfrom
jiaqizho:add-a-fio-test-for-ps

Conversation

@jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Nov 18, 2021

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and how it works?

Proposal:

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2021
JaySon-Huang
JaySon-Huang approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2021
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Nov 18, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2021

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 3edc48a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2021

@jiaqizho: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Nov 18, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/116/cobertura/
(Coverage detail url is limited office network access)

lines: 35.5% (43332 out of 122163)
branches: 5.4% (65904 out of 1220009)

@ti-chi-bot ti-chi-bot merged commit e655a42 into pingcap:master Nov 18, 2021
@JaySon-Huang JaySon-Huang deleted the add-a-fio-test-for-ps branch November 18, 2021 10:16
@JaySon-Huang JaySon-Huang mentioned this pull request Dec 3, 2021
Closed
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jiaqizho @ti-chi-bot @sre-bot @JaySon-Huang