Skip to content

PageStorage MVCC refine : removed VersionSet and VersionSetWithDelta header file#3422

Merged
ti-chi-bot merged 8 commits intopingcap:masterfrom
jiaqizho:pagestorage-mvcc-refine
Nov 15, 2021
Merged

PageStorage MVCC refine : removed VersionSet and VersionSetWithDelta header file#3422
ti-chi-bot merged 8 commits intopingcap:masterfrom
jiaqizho:pagestorage-mvcc-refine

Conversation

@jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Nov 11, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #3411

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

  1. removed interface form Page/mvcc/VersionSetWithDelta(only one sub class used) and delete the VersionSet(no more used)
  2. moved .h which under Page/mvcc into Page/V2/mvcc/PageEntriesVersionSetWithDelta.h as a hard logic.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 11, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 11, 2021
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Nov 11, 2021

/run-unit-test

@JaySon-Huang
Add back gtest_page_entry_map.cpp
1a319c2 
Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
JaySon-Huang reviewed Nov 11, 2021
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some changes and add gtest_page_entry_map.cpp back.

And I think we can also merge Storages/Page/mvcc/VersionSetWithDelta.h into Storages/Page/V2/VersionSet/PageEntriesVersionSetWithDelta.h
https://github.com/pingcap/tics/blob/1a319c21b2df5eba7568ace6c26f73f18dfba87f/dbms/src/Storages/Page/mvcc/VersionSetWithDelta.h#L125-L137

@jiaqizho
Copy link
Contributor Author

jiaqizho commented Nov 15, 2021

I've made some changes and add gtest_page_entry_map.cpp back.

And I think we can also merge Storages/Page/mvcc/VersionSetWithDelta.h into Storages/Page/V2/VersionSet/PageEntriesVersionSetWithDelta.h

https://github.com/pingcap/tics/blob/1a319c21b2df5eba7568ace6c26f73f18dfba87f/dbms/src/Storages/Page/mvcc/VersionSetWithDelta.h#L125-L137

done. moved VersionSetWithDelta.h.

@jiaqizho jiaqizho changed the title PageStorage MVCC refine : removed PageEntriesVersionSet.h PageStorage MVCC refine : removed VersionSet and VersionSetWithDelta header file Nov 15, 2021
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Nov 15, 2021

/run-all-tests

JaySon-Huang
JaySon-Huang approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 15, 2021
@jiaqizho @JaySon-Huang
Update dbms/src/Storages/Page/V2/VersionSet/PageEntriesVersionSetWith…
cb2841d 
…Delta.h

Co-authored-by: JaySon <jayson.hjs@gmail.com>
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Nov 15, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2021

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 15, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: cb2841d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2021
@ti-chi-bot ti-chi-bot merged commit e47e85e into pingcap:master Nov 15, 2021
@JaySon-Huang JaySon-Huang deleted the pagestorage-mvcc-refine branch November 15, 2021 09:42
@JaySon-Huang JaySon-Huang mentioned this pull request Dec 3, 2021
Closed
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Merge PageEntriesVersionSet.h and PageEntriesVersionSetWithDelta.h, remove outdated codes to make it more clear and easier to understand

3 participants

@jiaqizho @ti-chi-bot @JaySon-Huang