Skip to content

PageStorage refine : Split the different version of PageStorage#3320

Merged
ti-chi-bot merged 11 commits intopingcap:masterfrom
jiaqizho:pagestorage-refine-1
Nov 8, 2021
Merged

PageStorage refine : Split the different version of PageStorage#3320
ti-chi-bot merged 11 commits intopingcap:masterfrom
jiaqizho:pagestorage-refine-1

Conversation

@jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Oct 28, 2021

What problem does this PR solve?

Issue Number:

Problem Summary:

relative to #3269 part 1

What is changed and how it works?

Proposal: refine pagestorage

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 28, 2021
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Oct 28, 2021

/assign @jiaqizho

@jiaqizho
Copy link
Contributor Author

jiaqizho commented Oct 28, 2021

/run-all-tests

@jiaqizho jiaqizho requested a review from lidezhu October 29, 2021 02:53
JaySon-Huang
JaySon-Huang reviewed Oct 29, 2021
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge until branch "release-5.3" is created

JaySon-Huang
JaySon-Huang reviewed Nov 4, 2021
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed Nov 4, 2021
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed Nov 4, 2021
View reviewed changes
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Nov 5, 2021

/run-all-tests

@jiaqizho
Copy link
Contributor Author

jiaqizho commented Nov 8, 2021

/run-all-tests

@JaySon-Huang
Remove PageCreator.h
cb29b04 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2021
@JaySon-Huang
format
2a0ff6a 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Nov 8, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 8, 2021

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 8, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 2a0ff6a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2021
@ti-chi-bot ti-chi-bot merged commit 7242f40 into pingcap:master Nov 8, 2021
@JaySon-Huang JaySon-Huang mentioned this pull request Dec 3, 2021
Closed
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

@lidezhu lidezhu Awaiting requested review from lidezhu

Assignees

@jiaqizho jiaqizho

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiaqizho @ti-chi-bot @JaySon-Huang