Skip to content

fix 2894, 2944, 2945, 2946#3305

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
ywqzzy:ywq_fix_clang_tidy_9
Nov 16, 2021
Merged

fix 2894, 2944, 2945, 2946#3305
ti-chi-bot merged 5 commits intopingcap:masterfrom
ywqzzy:ywq_fix_clang_tidy_9

Conversation

@ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Oct 27, 2021

What problem does this PR solve?

Issue Number: close #2894 #2944 #2946

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 27, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2021
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2021
@ywqzzy ywqzzy force-pushed the ywq_fix_clang_tidy_9 branch from b9ed6f8 to ee3f4d4 Compare November 2, 2021 08:25
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 2, 2021
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2021
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Nov 16, 2021

/run-all-tests

@JaySon-Huang
Format files
ff70c87 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 16, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Nov 16, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/82/cobertura/

@JaySon-Huang
Format files
a8f9cae 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Nov 16, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2021

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: a8f9cae

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 16, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Nov 16, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/83/cobertura/

@ti-chi-bot ti-chi-bot merged commit c66fc16 into pingcap:master Nov 16, 2021
@JaySon-Huang JaySon-Huang deleted the ywq_fix_clang_tidy_9 branch November 17, 2021 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix clang-tidy error in libs_libcommon_include_ext_range_h.txt

5 participants

@ywqzzy @ti-chi-bot @JaySon-Huang @sre-bot @fuzhe1989