Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
dbms/src/Common/UTF8Helpers.h
Outdated
| { | ||
| size_t res = 0; | ||
| const auto end = data + size; | ||
| const auto *const end = data + size; |
There was a problem hiding this comment.
the second const is unnecessary.
dbms/src/Common/UTF8Helpers.h
Outdated
| #if __SSE2__ | ||
| constexpr auto bytes_sse = sizeof(__m128i); | ||
| const auto src_end_sse = data + size / bytes_sse * bytes_sse; | ||
| const auto *const src_end_sse = data + size / bytes_sse * bytes_sse; |
| std::string source = msg.getSource(); | ||
| const std::string &source = msg.getSource(); | ||
| if (!source.empty()) | ||
| message = source + ": " + msg.getText(); |
There was a problem hiding this comment.
how about use fmt::format?
|
/merge |
|
@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 364aa2a |
|
@ywqzzy: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #2907 #2937 #2916
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note