Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
dbms/src/Common/SmallObjectPool.h
Outdated
| if (free_list) | ||
| { | ||
| const auto res = reinterpret_cast<char *>(free_list); | ||
| auto *const res = reinterpret_cast<char *>(free_list); |
There was a problem hiding this comment.
| auto *const res = reinterpret_cast<char *>(free_list); | |
| auto * res = reinterpret_cast<char *>(free_list); |
There was a problem hiding this comment.
error: 'const auto res' can be declared as 'auto *const res' [readability-qualified-auto,-warnings-as-errors]
dbms/src/Common/SmallObjectPool.h
Outdated
| if (free_list) | ||
| { | ||
| const auto res = reinterpret_cast<char *>(free_list); | ||
| auto *const res = reinterpret_cast<char *>(free_list); |
There was a problem hiding this comment.
| auto *const res = reinterpret_cast<char *>(free_list); | |
| auto * const res = reinterpret_cast<char *>(free_list); |
a528810 to
78936dc
Compare
|
/merge |
|
@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 78936dc |
What problem does this PR solve?
Issue Number: close #2911 #2912 #2913 #2932
Problem Summary:
What is changed and how it works?
Proposal: [xxx]
What's Changed:
Related changes
pingcap/docs/pingcap/docs-cn:Tests
Side effects
Release note