Skip to content

clang-tidy: fix dbms/src/Common/HyperLogLogCounter.h Increment.h LRUCache.h#3083

Merged
ti-chi-bot merged 6 commits intopingcap:masterfrom
wshwsh12:tidy-some-files
Sep 17, 2021
Merged

clang-tidy: fix dbms/src/Common/HyperLogLogCounter.h Increment.h LRUCache.h#3083
ti-chi-bot merged 6 commits intopingcap:masterfrom
wshwsh12:tidy-some-files

Conversation

@wshwsh12
Copy link
Contributor

@wshwsh12 wshwsh12 commented Sep 14, 2021

What problem does this PR solve?

Issue Number:
close #2895
close #2962
close #2963

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 14, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 14, 2021
@wshwsh12 wshwsh12 requested a review from fuzhe1989 September 14, 2021 08:46
JaySon-Huang
JaySon-Huang reviewed Sep 14, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2021
@fuzhe1989
Copy link
Contributor

fuzhe1989 commented Sep 17, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 17, 2021

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 17, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: bfdda2a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 17, 2021
@ti-chi-bot ti-chi-bot merged commit ce37491 into pingcap:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

+1 more reviewer

@SchrodingerZhu SchrodingerZhu SchrodingerZhu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

5 participants

@wshwsh12 @ti-chi-bot @fuzhe1989 @JaySon-Huang @SchrodingerZhu