Skip to content

fix clang-tidy check in callOnTypeIndex.h#3079

Merged
ti-chi-bot merged 3 commits intomasterfrom
xhy/issue_2928
Sep 15, 2021
Merged

fix clang-tidy check in callOnTypeIndex.h#3079
ti-chi-bot merged 3 commits intomasterfrom
xhy/issue_2928

Conversation

@XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Sep 14, 2021

What problem does this PR solve?

Issue Number: close #2928

Problem Summary:

/home/fuzhe/projects/tics/dbms/src/Core/callOnTypeIndex.h:49:64: error: use of undeclared identifier 'Decimal32' [clang-diagnostic-error]
            case TypeIndex::Decimal32:    return f(TypePair<T, Decimal32>());
                                                               ^
/home/fuzhe/projects/tics/dbms/src/Core/callOnTypeIndex.h:50:64: error: use of undeclared identifier 'Decimal64' [clang-diagnostic-error]
            case TypeIndex::Decimal64:    return f(TypePair<T, Decimal64>());
                                                               ^
/home/fuzhe/projects/tics/dbms/src/Core/callOnTypeIndex.h:51:64: error: use of undeclared identifier 'Decimal128' [clang-diagnostic-error]
            case TypeIndex::Decimal128:   return f(TypePair<T, Decimal128>());
                                                               ^
/home/fuzhe/projects/tics/dbms/src/Core/callOnTypeIndex.h:52:64: error: use of undeclared identifier 'Decimal256' [clang-diagnostic-error]
            case TypeIndex::Decimal256:   return f(TypePair<T, Decimal256>());
                                                               ^
/home/fuzhe/projects/tics/dbms/src/Core/callOnTypeIndex.h:114:63: error: use of undeclared identifier 'Decimal32' [clang-diagnostic-error]
            case TypeIndex::Decimal32: return callOnBasicType<Decimal32, _int, _float, _decimal, _datetime>(type_num2, std::forward<F>(f));
                                                              ^
/home/fuzhe/projects/tics/dbms/src/Core/callOnTypeIndex.h:115:63: error: use of undeclared identifier 'Decimal64' [clang-diagnostic-error]
            case TypeIndex::Decimal64: return callOnBasicType<Decimal64, _int, _float, _decimal, _datetime>(type_num2, std::forward<F>(f));
                                                              ^
/home/fuzhe/projects/tics/dbms/src/Core/callOnTypeIndex.h:116:64: error: use of undeclared identifier 'Decimal128' [clang-diagnostic-error]
            case TypeIndex::Decimal128: return callOnBasicType<Decimal128, _int, _float, _decimal, _datetime>(type_num2, std::forward<F>(f));
                                                               ^
/home/fuzhe/projects/tics/dbms/src/Core/callOnTypeIndex.h:117:64: error: use of undeclared identifier 'Decimal256' [clang-diagnostic-error]
            case TypeIndex::Decimal256: return callOnBasicType<Decimal256, _int, _float, _decimal, _datetime>(type_num2, std::forward<F>(f));
                                                               ^
/home/fuzhe/projects/tics/dbms/src/Core/callOnTypeIndex.h:177:75: error: use of undeclared identifier 'Decimal32' [clang-diagnostic-error]
        case TypeIndex::Decimal32:      return f(TypePair<DataTypeDecimal<Decimal32>, T>());
                                                                          ^
/home/fuzhe/projects/tics/dbms/src/Core/callOnTypeIndex.h:178:75: error: use of undeclared identifier 'Decimal64' [clang-diagnostic-error]
        case TypeIndex::Decimal64:      return f(TypePair<DataTypeDecimal<Decimal64>, T>());
                                                                          ^
/home/fuzhe/projects/tics/dbms/src/Core/callOnTypeIndex.h:179:75: error: use of undeclared identifier 'Decimal128' [clang-diagnostic-error]
        case TypeIndex::Decimal128:     return f(TypePair<DataTypeDecimal<Decimal128>, T>());
                                                                          ^
/home/fuzhe/projects/tics/dbms/src/Core/callOnTypeIndex.h:180:75: error: use of undeclared identifier 'Decimal256' [clang-diagnostic-error]
        case TypeIndex::Decimal256:     return f(TypePair<DataTypeDecimal<Decimal256>, T>());
                                                                          ^

What is changed and how it works?

What's Changed:

Related changes

N/A

Check List

Tests

  • Manual test

Side effects

N/A

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 14, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2021
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Sep 15, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2021

@XuHuaiyu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: dd4e9d5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 15, 2021
@ti-chi-bot ti-chi-bot merged commit e4b1612 into master Sep 15, 2021
@JaySon-Huang JaySon-Huang deleted the xhy/issue_2928 branch September 15, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix clang-tidy error in dbms_src_Core_callOnTypeIndex_h.txt

3 participants

@XuHuaiyu @ti-chi-bot @fuzhe1989