Skip to content

Fix clang-tidy error in dbms_src_Columns_ColumnString_h.txt and dbms_src_Columns_ColumnString_cpp.txt#3069

Merged
ti-chi-bot merged 5 commits intopingcap:masterfrom
SeaRise:fix_column_string_tidy
Sep 10, 2021
Merged

Fix clang-tidy error in dbms_src_Columns_ColumnString_h.txt and dbms_src_Columns_ColumnString_cpp.txt#3069
ti-chi-bot merged 5 commits intopingcap:masterfrom
SeaRise:fix_column_string_tidy

Conversation

@SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Sep 10, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #2858, close #2857

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 10, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 10, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 10, 2021
@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 10, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 10, 2021

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 10, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: b115547

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 10, 2021
@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 10, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit c9e4dd7 into pingcap:master Sep 10, 2021
@SeaRise SeaRise deleted the fix_column_string_tidy branch September 13, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

Assignees

No one assigned

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix clang-tidy error in dbms_src_Columns_ColumnString_h.txt Fix clang-tidy error in dbms_src_Columns_ColumnString_cpp.txt

3 participants

@SeaRise @ti-chi-bot @fuzhe1989