Skip to content

Add more workload into page storage stress test#3057

Merged
ti-chi-bot merged 24 commits intopingcap:masterfrom
jiaqizho:stress-test-more-workload
Oct 26, 2021
Merged

Add more workload into page storage stress test#3057
ti-chi-bot merged 24 commits intopingcap:masterfrom
jiaqizho:stress-test-more-workload

Conversation

@jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Sep 9, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and how it works?

Proposal:

What's Changed:

  • Workload: heavy write load, heavy read load, skew write, skew read
  • Workload: Pages contains thousands of offset inside (mock wide table in the upper level)
  • Workload: some pages are not updated for a long time
  • Workload: some threads hold snapshots for a long time
  • Workload: upper-level DeltaMergeStore stress testing
  • Workload: one PageStorage supports a large number of Pages (What is the expected order of magnitude)
  • Refine some interface & bug fixes for page stress testing #3062 merge first. Then do clang-tidy.
  1. Workload: some pages are not updated for a long time ， same as HighValidBigFileGC , so removed
  2. Workload: upper-level DeltaMergeStore stress testing , need move to DeltaMergeStore stress, so move it to another test

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 9, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 9, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 9, 2021
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Sep 13, 2021

/assign jiaqizho

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2021
@jiaqizho jiaqizho changed the title [WIP]add more workload in page storage stress test Add more workload into page storage stress test Sep 18, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 18, 2021
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Sep 18, 2021

/rebuild

JaySon-Huang
JaySon-Huang reviewed Sep 26, 2021
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed Sep 26, 2021
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed Oct 25, 2021
View reviewed changes
JaySon-Huang
JaySon-Huang reviewed Oct 25, 2021
View reviewed changes
JaySon-Huang
JaySon-Huang approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2021
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Oct 26, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 26, 2021

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 26, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7cb143b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 26, 2021
@ti-chi-bot ti-chi-bot merged commit 4c1ef99 into pingcap:master Oct 26, 2021
@JaySon-Huang JaySon-Huang deleted the stress-test-more-workload branch October 26, 2021 11:20
@JaySon-Huang JaySon-Huang mentioned this pull request Nov 9, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@lidezhu lidezhu Awaiting requested review from lidezhu

Assignees

@jiaqizho jiaqizho

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jiaqizho @ti-chi-bot @JaySon-Huang