Skip to content

Move cpptoml to contrib#3046

Merged
ti-chi-bot merged 4 commits intopingcap:masterfrom
JaySon-Huang:fix_cpptoml
Sep 7, 2021
Merged

Move cpptoml to contrib#3046
ti-chi-bot merged 4 commits intopingcap:masterfrom
JaySon-Huang:fix_cpptoml

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Sep 7, 2021 •
edited by SchrodingerZhu
Loading

What problem does this PR solve?

Issue Number: close #2883

Problem Summary: cpptoml is a thrid-party lib from https://github.com/skystrife/cpptoml, we should exclude it from dbms and ignore the lints on it.

What is changed and how it works?

  • Move dbms/src/Common/Config/cpptoml.h → contrib/cpptoml/cpptoml.h
  • Add a library cpptoml for linking

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Integration test

Side effects

Release note 

None

@JaySon-Huang
Move cpptoml to contrib
87a0932 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Format
4ed3314 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang JaySon-Huang added the type/code-quality-improvement PR that can improve the code quality label Sep 7, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@JaySon-Huang JaySon-Huang self-assigned this Sep 7, 2021
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2021
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 7, 2021
@solotzg
Copy link
Contributor

solotzg commented Sep 7, 2021

lgtm

@JaySon-Huang
Fix compile error for page_ctl
feae671 
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Copy link
Contributor Author

JaySon-Huang commented Sep 7, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2021

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: feae671

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 7, 2021
@ti-chi-bot ti-chi-bot merged commit 4432e3e into pingcap:master Sep 7, 2021
@JaySon-Huang JaySon-Huang deleted the fix_cpptoml branch September 7, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

@solotzg solotzg Awaiting requested review from solotzg

Assignees

@JaySon-Huang JaySon-Huang

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/code-quality-improvement PR that can improve the code quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix clang-tidy error in dbms_src_Common_Config_cpptoml_h.txt

4 participants

@JaySon-Huang @ti-chi-bot @solotzg @fuzhe1989