Skip to content

Fix mem utils and crc64 tidy#3045

Merged
ti-chi-bot merged 7 commits intopingcap:masterfrom
SchrodingerZhu:fix-mem-utils-tidy
Sep 9, 2021
Merged

Fix mem utils and crc64 tidy#3045
ti-chi-bot merged 7 commits intopingcap:masterfrom
SchrodingerZhu:fix-mem-utils-tidy

Conversation

@SchrodingerZhu
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu commented Sep 7, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close #2950, close #2949, close #2948 , close #2930, close #2966
Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 7, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2021
@SchrodingerZhu SchrodingerZhu changed the title Fix mem utils tidy Fix mem utils and crc64 tidy Sep 7, 2021
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2021
@SchrodingerZhu SchrodingerZhu self-assigned this Sep 7, 2021
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Sep 7, 2021

I'm curious about 774e329 which contains "critical bug found" in the message. Could you elaborate more?

@SchrodingerZhu
fix mem_utils_sse2
39f5d20 
Signed-off-by: Schrodinger ZHU Yifan <i@zhuyi.fan>
@SchrodingerZhu
Copy link
Contributor Author

SchrodingerZhu commented Sep 7, 2021

@JaySon-Huang It turns out not to be a bug. I will trim the message.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 7, 2021
fuzhe1989
fuzhe1989 approved these changes Sep 8, 2021
View reviewed changes
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 8, 2021
SchrodingerZhu and others added 5 commits September 9, 2021 04:13
@SchrodingerZhu
fix mem_utils_avx512
e9a2ffe 
Signed-off-by: Schrodinger ZHU Yifan <i@zhuyi.fan>
@SchrodingerZhu
fix mem_utils_avx2
90aee9a 
Signed-off-by: Schrodinger ZHU Yifan <i@zhuyi.fan>
@SchrodingerZhu
fix headers
f711469 
Signed-off-by: Schrodinger ZHU Yifan <i@zhuyi.fan>
@SchrodingerZhu
format
38d4901 
Signed-off-by: Schrodinger ZHU Yifan <i@zhuyi.fan>
@SchrodingerZhu @fuzhe1989
Update libs/libcommon/include/common/crc64_arch/crc64_aarch64.h
d2016a6 
Co-authored-by: Fu Zhe <fuzhe1989@gmail.com>
@SchrodingerZhu
Copy link
Contributor Author

SchrodingerZhu commented Sep 8, 2021

/merge

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2021

@SchrodingerZhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2021

This pull request has been accepted and is ready to merge.

DetailsCommit hash: d2016a6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 8, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 8, 2021

@SchrodingerZhu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit c374410 into pingcap:master Sep 9, 2021
@JaySon-Huang JaySon-Huang deleted the fix-mem-utils-tidy branch September 9, 2021 04:49
@Mini256 Mini256 mentioned this pull request Oct 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

Assignees

@SchrodingerZhu SchrodingerZhu

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Milestone

No milestone

4 participants

@SchrodingerZhu @ti-chi-bot @JaySon-Huang @fuzhe1989