Skip to content

Remove the mutable tests that are already disabled#2807

Merged
JaySon-Huang merged 4 commits intopingcap:masterfrom
JaySon-Huang:remove_useless_mutable
Aug 28, 2021
Merged

Remove the mutable tests that are already disabled#2807
JaySon-Huang merged 4 commits intopingcap:masterfrom
JaySon-Huang:remove_useless_mutable

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Aug 28, 2021

Signed-off-by: JaySon-Huang jayson.hjs@gmail.com

What problem does this PR solve?

A part of #2717

Remove useless test cases from the directory tests/mutable-test.
This PR remove the cases that are already disabled (starts with #RETURN)

What is changed and how it works?

  • These cases are useless or covered by other tests for DeltaTree
    • bugs/delete-version.test: the SQL API for MergeTree
    • bugs/{bugs/prewhere,prewhere_in_subquery}.test: the prewhere statement for MergeTree
    • merge_tree/alter.test: simple DDL operations
    • merge_tree/merge_tree.test: simple read/write
    • mutable_delete/: delete rows in MutableMergeTree(mmt for short)
    • mutable_syntax/alter.test: DDL operations, can not alter hidden columns (primary key, version, delete_mark)
    • mutable_syntax/delete.test: the delete SQL for mmt
    • mutable_syntax/desc.test: showing the table structure for mmt
    • mutable_syntax/import.test: "import" syntax add hidden column for mmt
    • mutable_syntax/insert.test: "insert ... from select" syntax add hidden column for mmt
    • mutable_syntax/insert_select.test: "insert" syntax add hidden column for mmt
    • mutable_syntax/order_by.test: sort the result set
    • mutable_syntax/reverse_insert.test: insert with not sorted block
    • mutable_syntax/select.test: simple read write
    • mutable_syntax/selraw.test: read with hidden column
    • mutable_syntax/upsert.test: upserting rows
    • txn_mock/region.test: mocking insert some rows concurrently through Raft
    • txn_mock/same_version_diff_delmark.test: mocking insert some rows through Raft then read with MVCC filtering
    • txn_mock/data_only_in_region.test: read with MVCC filtering that data didn't get flushed into the storage layer

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • No code

Side effects

Release note

None

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang JaySon-Huang added the type/code-quality-improvement PR that can improve the code quality label Aug 28, 2021
@JaySon-Huang JaySon-Huang self-assigned this Aug 28, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 28, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 28, 2021
@JaySon-Huang JaySon-Huang requested a review from fuzhe1989 August 28, 2021 15:00
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 28, 2021
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
@JaySon-Huang
Copy link
Contributor Author

The cases left on mutable-test need further modification, I will move them in another PR.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 28, 2021
@fuzhe1989
Copy link
Contributor

/run-all-tests

@JaySon-Huang JaySon-Huang merged commit 4cf158b into pingcap:master Aug 28, 2021
@JaySon-Huang JaySon-Huang deleted the remove_useless_mutable branch August 28, 2021 15:51
@JaySon-Huang JaySon-Huang mentioned this pull request Nov 23, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. type/code-quality-improvement PR that can improve the code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants