Skip to content

ascii, coalesce, length, position, trim pushdown#2618

Merged
xzhangxian1008 merged 5 commits intopingcap:masterfrom
xzhangxian1008:master
Aug 7, 2021
Merged

ascii, coalesce, length, position, trim pushdown#2618
xzhangxian1008 merged 5 commits intopingcap:masterfrom
xzhangxian1008:master

Conversation

@xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #2424 #2334

Problem Summary: add pushdown functions

What is changed and how it works?

What's Changed:

  • add ascii, length, position pushdown functions (coalesce and trim have existed in ch)
  • add gtests of ascii, length, position
  • add integration tests of ascii, length, position, coalesce, trim

Related changes

  • PR to update tiflash/integration:

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@xzhangxian1008
Copy link
Contributor Author

/run-all-tests

@xzhangxian1008
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 7, 2021
@xzhangxian1008
Copy link
Contributor Author

/run-all-tests

@xzhangxian1008 xzhangxian1008 merged commit 90f8fab into pingcap:master Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Push down string related functions - ASCII, length, position, trim

3 participants