Push down ROUND(x) on decimal types (#2492)#2611
Closed
ti-srebot wants to merge 2 commits intopingcap:release-5.1from
Closed
Push down ROUND(x) on decimal types (#2492)#2611ti-srebot wants to merge 2 commits intopingcap:release-5.1from
ROUND(x) on decimal types (#2492)#2611ti-srebot wants to merge 2 commits intopingcap:release-5.1from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #2492 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/2611After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #2426, part of #2550
Problem Summary: enable
ROUND(x)on TiFlash.What is changed and how it works?
What's Changed:
IDataType.h,DataTypesNumber.h: addisFloatingPoint.DAGExpressionAnalyzer.cpp: constructtidbRoundfromtidbRoundWithFrac.DAGUtils.cpp: map TiPB codes to function names.FunctionsArithmetic.h,toUnsigned.h: move outtoUnsignedfor reusing inFunctionsRound.h.FunctionsRound.cpp: register new function.FunctionsRound.h: the implementation.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note
ROUND(X)to TiFlash.