Skip to content

Push down function DATE() to tiflash (#2501)#2601

Merged
mengxin9014 merged 1 commit intopingcap:release-5.0from
ti-srebot:release-5.0-0552b714a98b
Aug 6, 2021
Merged

Push down function DATE() to tiflash (#2501)#2601
mengxin9014 merged 1 commit intopingcap:release-5.0from
ti-srebot:release-5.0-0552b714a98b

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Aug 6, 2021

cherry-pick #2501 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2601

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/2601:release-5.0-0552b714a98b

What problem does this PR solve?

Issue Number: close ##2450

Problem Summary:
Push down function DATE() to tiflash

What is changed and how it works?

What's Changed:
Push down function DATE() to tiflash

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Integration test

Release note

  • support function DATE() pushed down to tiflash

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added the CHERRY-PICK cherry pick label Aug 6, 2021
@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement. labels Aug 6, 2021
@ti-srebot ti-srebot requested a review from LittleFall August 6, 2021 05:19
@ti-srebot ti-srebot added this to the v5.0.4 milestone Aug 6, 2021
@mengxin9014
Copy link
Contributor

/run-all-tests

@mengxin9014 mengxin9014 requested a review from hanfei1991 August 6, 2021 06:16
Copy link
Contributor

@LittleFall LittleFall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Collaborator Author

@LittleFall, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack).

@mengxin9014
Copy link
Contributor

/merge

@ti-srebot
Copy link
Collaborator Author

@mengxin9014 Oops! This PR requires at least 1 LGTMs to merge. The current number of LGTM is 0

@mengxin9014 mengxin9014 merged commit 8716c90 into pingcap:release-5.0 Aug 6, 2021
@LittleFall LittleFall deleted the release-5.0-0552b714a98b branch August 6, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants