Skip to content

Push down ADDDATE(), DATE_ADD() on String, Real types (#2454)#2591

Closed
ti-srebot wants to merge 1 commit intopingcap:release-5.1from
ti-srebot:release-5.1-36756d955e25
Closed

Push down ADDDATE(), DATE_ADD() on String, Real types (#2454)#2591
ti-srebot wants to merge 1 commit intopingcap:release-5.1from
ti-srebot:release-5.1-36756d955e25

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Aug 5, 2021

cherry-pick #2454 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2591

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/2591:release-5.1-36756d955e25

What problem does this PR solve?

Issue Number: close #2450

Problem Summary:

support ADDDATE() and DATE_ADD() pushed down to tiflash

What is changed and how it works?

support ADDDATE() and DATE_ADD() pushed down to tiflash

Check List

Tests

  • Integration test

Release note

  • support functions of ADDDATE() and DATE_ADD() pushed down to tiflash

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added CHERRY-PICK cherry pick component/expression status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement. labels Aug 5, 2021
@ti-srebot ti-srebot added this to the v5.1.2 milestone Aug 5, 2021
@mengxin9014
Copy link
Contributor

/run-all-tests

@JaySon-Huang JaySon-Huang modified the milestones: v5.1.2, v5.1.3 Oct 11, 2021
@JaySon-Huang JaySon-Huang modified the milestones: v5.1.3, v5.1.4 Dec 28, 2021
@JaySon-Huang
Copy link
Contributor

Closed by triage reject.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CHERRY-PICK cherry pick component/expression status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants