Refine some include headers & add option ENABLE_FAILPOINTS (#2296)#2480
Closed
ti-srebot wants to merge 2 commits intopingcap:release-5.0from
Closed
Refine some include headers & add option ENABLE_FAILPOINTS (#2296)#2480ti-srebot wants to merge 2 commits intopingcap:release-5.0from
ENABLE_FAILPOINTS (#2296)#2480ti-srebot wants to merge 2 commits intopingcap:release-5.0from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
|
/run-all-tests |
Contributor
|
/reopen |
Member
|
@LittleFall: Failed to re-open PR: state cannot be changed. The pull request cannot be reopened. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #2296 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/2480After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: related to #2295
What is changed and how it works?
cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DENABLE_TESTS=OFF -DENABLE_FAILPOINTS=ON ..This can remove dependency for some targets (
page_storagefor example) and make it easier to write and run unit tests.Related changes
Check List
Tests
Side effects
Release note