Revert snapshot on release-5.0 branch#2121
Merged
JaySon-Huang merged 6 commits intopingcap:release-5.0from Jun 8, 2021
Merged
Conversation
…-5.0 (pingcap#2074)" This reverts commit 8e0712c.
…2054) (pingcap#2055)" This reverts commit c773d61.
…ngcap#2048)" This reverts commit b329618.
…ap#1439) (pingcap#1867)" This reverts commit c947fd6. Conflicts: dbms/src/Common/FailPoint.cpp dbms/src/Storages/DeltaMerge/File/DMFileBlockOutputStream.h dbms/src/Storages/DeltaMerge/File/DMFileWriter.h dbms/src/Storages/DeltaMerge/ReorganizeBlockInputStream.h dbms/src/Storages/DeltaMerge/SSTFilesToBlockInputStream.cpp dbms/src/Storages/DeltaMerge/SSTFilesToBlockInputStream.h dbms/src/Storages/DeltaMerge/SSTFilesToDTFilesOutputStream.cpp dbms/src/Storages/DeltaMerge/Segment.cpp dbms/src/Storages/DeltaMerge/StableValueSpace.cpp dbms/src/Storages/DeltaMerge/tests/gtest_dm_file.cpp dbms/src/Storages/DeltaMerge/tests/gtest_dm_storage_delta_merge.cpp dbms/src/Storages/StorageDeltaMerge.cpp dbms/src/Storages/StorageDeltaMerge.h dbms/src/Storages/Transaction/ApplySnapshot.cpp dbms/src/Storages/Transaction/PartitionStreams.cpp tests/delta-merge-test/raft/schema/drop_on_restart.test
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
Author
|
We review this PR by: |
Contributor
Author
|
/run-all-tests |
This was referenced Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Rollback "Apply snapshot optimization" for v5.0.2 because we find #2118 that will make TiFlash crash when a table "pk is handle" is true.
What is changed and how it works?
Revert #2070, #2074 that should not bring to v5.0.2.
Revert #1867 and its following bug-fixes #2048, #2055 from v5.0.2
Note that #2070, #2074 will be restored after this PR merged.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note