Skip to content

*: remove extra qualifiers in casting#2107

Merged
ti-srebot merged 2 commits intopingcap:masterfrom
SchrodingerZhu:fix-ignored-qualifiers
Jun 7, 2021
Merged

*: remove extra qualifiers in casting#2107
ti-srebot merged 2 commits intopingcap:masterfrom
SchrodingerZhu:fix-ignored-qualifiers

Conversation

@SchrodingerZhu
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu commented Jun 7, 2021

Signed-off-by: SchrodingerZhu i@zhuyi.fan

What problem does this PR solve?

Issue Number: #2064

Problem Summary:

It is of no semantic to add cv qualifier in value type casting. This also lead to warnings.

Check List

Tests

  • Unit test
  • Integration test

Release note

No release note

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@SchrodingerZhu SchrodingerZhu changed the title : remove extra qualifiers in casting *: remove extra qualifiers in casting Jun 7, 2021
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 7, 2021
@JaySon-Huang
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 7, 2021
@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2095
  • 2104

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 220e6cb into pingcap:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants