Skip to content

*: fix sign comparison warning#2101

Merged
ti-srebot merged 4 commits intopingcap:masterfrom
SchrodingerZhu:fix-sign-comparison
Jun 11, 2021
Merged

*: fix sign comparison warning#2101
ti-srebot merged 4 commits intopingcap:masterfrom
SchrodingerZhu:fix-sign-comparison

Conversation

@SchrodingerZhu
Copy link
Contributor

Signed-off-by: SchrodingerZhu i@zhuyi.fan

What problem does this PR solve?

Issue Number: #2064

What is changed and how it works?

What's Changed:

explicit cast before comparison

Check List

Tests

  • Unit test
  • Integration test

Release note

No release note

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@SchrodingerZhu SchrodingerZhu changed the title : fix sign comparison warning *: fix sign comparison warning Jun 7, 2021
@fuzhe1989
Copy link
Contributor

LGTM

@ti-srebot
Copy link
Collaborator

@fuzhe1989, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiflash(slack).

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 11, 2021
@JaySon-Huang
Copy link
Contributor

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2110

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@SchrodingerZhu merge failed.

@SchrodingerZhu
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2142
  • 2138
  • 2141

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@SchrodingerZhu merge failed.

@JaySon-Huang
Copy link
Contributor

/run-all-tests

@SchrodingerZhu
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2142
  • 2141
  • 2138

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 588e4a2 into pingcap:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants