*: fix catching polymorphic type ‘class std::out_of_range’ by value#2095
Merged
ti-srebot merged 2 commits intopingcap:masterfrom Jun 7, 2021
Merged
*: fix catching polymorphic type ‘class std::out_of_range’ by value#2095ti-srebot merged 2 commits intopingcap:masterfrom
catching polymorphic type ‘class std::out_of_range’ by value#2095ti-srebot merged 2 commits intopingcap:masterfrom
Conversation
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Contributor
Author
|
/run-all-tests |
catching polymorphic type ‘class std::out_of_range’ by valuecatching polymorphic type ‘class std::out_of_range’ by value
Contributor
|
/merge |
Collaborator
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SchrodingerZhu i@zhuyi.fan
What problem does this PR solve?
Issue Number: address the first problem in #2064
What is changed and how it works?
What's Changed:
catch by const reference.
Check List
Tests
Release note
No release note