Skip to content

function: Support push function year,day,datediff,datesub,castTimeAsString,concat_ws down to TiFlash. (#2084)#2089

Merged
ti-srebot merged 6 commits intopingcap:release-5.0from
ti-srebot:release-5.0-0ed0a075da1f
Jun 18, 2021
Merged

function: Support push function year,day,datediff,datesub,castTimeAsString,concat_ws down to TiFlash. (#2084)#2089
ti-srebot merged 6 commits intopingcap:release-5.0from
ti-srebot:release-5.0-0ed0a075da1f

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jun 4, 2021

cherry-pick #2084 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/2089

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/2089:release-5.0-0ed0a075da1f

What problem does this PR solve?

Issue Number: close #1480

Problem Summary: Support push fucntion year,day,datediff,datesub,castTimeAsString down to TiFlash.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch: 5.0

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@LittleFall LittleFall requested a review from leiysky June 18, 2021 13:09
Copy link
Contributor

@leiysky leiysky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LittleFall
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 18, 2021
@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot ti-srebot merged commit 13d2de9 into pingcap:release-5.0 Jun 18, 2021
@LittleFall LittleFall deleted the release-5.0-0ed0a075da1f branch June 19, 2021 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CHERRY-PICK cherry pick status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants