Fix compile error on Mac Clang 12.0.5 (#2058)#2069
Merged
zanmato1984 merged 1 commit intopingcap:release-4.0from Jun 3, 2021
Merged
Fix compile error on Mac Clang 12.0.5 (#2058)#2069zanmato1984 merged 1 commit intopingcap:release-4.0from
zanmato1984 merged 1 commit intopingcap:release-4.0from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
/merge |
Collaborator
Author
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #2058 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/2069After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #1887
Problem Summary:
There are a lot of changes since Mac Clang 12.0.5 comparing to 12.0.0. These changes bring up unintended compiler warning and errors.
To see some of what's changed in Mac Clang 12.0.5, please try this little program: https://github.com/zanmato1984/clang-1205-test
What is changed and how it works?
Regulate some codes.
Ignore some warnings.