Skip to content

libdivide: update to 4.0.0#2062

Merged
ti-srebot merged 9 commits intopingcap:masterfrom
SchrodingerZhu:libdivide-update
Jun 8, 2021
Merged

libdivide: update to 4.0.0#2062
ti-srebot merged 9 commits intopingcap:masterfrom
SchrodingerZhu:libdivide-update

Conversation

@SchrodingerZhu
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu commented Jun 3, 2021

Signed-off-by: SchrodingerZhu i@zhuyi.fan

What problem does this PR solve?

Problem Summary: #2064
old libdivide is causing warnings like ignoring attributes on template argument (-Wignored-attributes)

What is changed and how it works?

What's Changed:

  • update libdivide
wget https://raw.githubusercontent.com/ridiculousfish/libdivide/fdbafd427f329b3c1ccafcdc13a354e88c596787/libdivide.h -O libdivide.h 

Related changes

None

Check List

Tests

  • Unit test
  • Integration test

Release note

No release note

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
@fuzhe1989
Copy link
Contributor

LGTM

good job

@SchrodingerZhu
Copy link
Contributor Author

will fix

LIBDIVIDE_USE_SSE2 -> LIBDIVIDE_SSE2

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@SchrodingerZhu
Copy link
Contributor Author

SchrodingerZhu commented Jun 8, 2021

this also enables us to use avx and neon in the future. in fact, CH is already using them.

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 8, 2021
@SchrodingerZhu
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 9b833a2 into pingcap:master Jun 8, 2021
@JaySon-Huang JaySon-Huang deleted the libdivide-update branch March 4, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants