Fix the bug that incomplete write batches are not truncated (#1934)#2002
Merged
ti-srebot merged 6 commits intopingcap:release-4.0from May 27, 2021
Merged
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Contributor
|
/run-all-tests |
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com> Conflicts: dbms/src/Functions/tests/gtest_datetime_extract.cpp dbms/src/Storages/DeltaMerge/tests/gtest_dm_delta_index_manager.cpp dbms/src/TestUtils/TiFlashTestBasic.h
flowbehappy
approved these changes
May 27, 2021
Contributor
|
/merge |
Collaborator
Author
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #1934 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/2002After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #1932
Problem Summary: as the issue descript
What is changed and how it works?
If there is any incomplete write batch get ignored, truncate the meta file to throw away broken data
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
meta_on_disk.setSize(meta_file_pos);insidePageFile::setFileAppendPos, we can see error while runningPageStorage_test.IgnoreIncompleteWriteBatch1::ftruncate(file->getFd(), offset);insidewriteFile, we can see error while runningPageStorage_test.IgnoreIncompleteWriteBatch2Side effects
Release note