Skip to content

Fix bug for str_to_date nullable input column#1984

Merged
zanmato1984 merged 3 commits intopingcap:v5.0.1_may_pocfrom
JaySon-Huang:str_to_date_pushdown_hotfix
May 24, 2021
Merged

Fix bug for str_to_date nullable input column#1984
zanmato1984 merged 3 commits intopingcap:v5.0.1_may_pocfrom
JaySon-Huang:str_to_date_pushdown_hotfix

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented May 24, 2021

Signed-off-by: JaySon-Huang jayson.hjs@gmail.com

What problem does this PR solve?

Issue Number: a part of #1942

Problem Summary: If the input column of str_to_date is a nullable column, it will generate incorrect results

What is changed and how it works?

  • Fix bug for nullable column
  • Remove unreasonable include file to make compiling faster

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label May 24, 2021
@zanmato1984 zanmato1984 merged commit 254fb4b into pingcap:v5.0.1_may_poc May 24, 2021
@JaySon-Huang JaySon-Huang deleted the str_to_date_pushdown_hotfix branch May 24, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants