Avoid recalculate stable property when stable is empty#1876
Merged
Avoid recalculate stable property when stable is empty#1876
Conversation
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
This fix is also included in this cherry pick pr: #1878 |
Contributor
|
/merge |
JaySon-Huang
approved these changes
May 10, 2021
Contributor
Author
|
/merge |
Collaborator
|
/run-all-tests |
Collaborator
|
@lidezhu merge failed. |
Contributor
|
/rebuild |
Contributor
Author
|
/merge |
Collaborator
|
Your auto merge job has been accepted, waiting for:
|
Collaborator
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary: when an old cluster have a lot of empty stable file(e.g. table that don't have tiflash replica), after upgrade it will try to calculate stable property which is useless work.
What is changed and how it works?
Proposal: xxx
What's Changed: Add more check to avoid calculate stable property for empty tables after upgrading.
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note