Fix the wrong result of reading single format DTFile & misplaced Grafana panel (#1803)#1806
Merged
JaySon-Huang merged 1 commit intopingcap:release-5.0from Apr 21, 2021
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
/run-all-tests |
lidezhu
approved these changes
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #1803 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/1806After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #1787
Problem Summary:
Region write Duration (write blocks)appear in weird places. It is because the panel share a same "id=77" with the panelHandling Request NumberWhat is changed and how it works?
DoDMFile::initializeSubFileStatIfNeededinsideDMFilePackFilter::initto ensure we can load min-max indexes if they exist.DMFile::initializeSubFileStatIfNeededinsideDMFile::readMeta.@lidezhu split the functions from
readMetato reduce the number of bytes read from the disk while initiating. But it brings another problem: We need to acquire a lock for checking whether the file is single-mode and sub_file_stats is empty every time we create a DMFileFilter. No matter the file is single-mode or directory-mode.Those data are small and we can optimize the initlizating by lazy init
DeltaMergeStore.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note
Region write Duration (write blocks)may be shown in wrong place