Skip to content

Delete range can not remove expected data (#1783)#1790

Merged
flowbehappy merged 1 commit intopingcap:release-5.0from
ti-srebot:release-5.0-c72c331726b4
Apr 16, 2021
Merged

Delete range can not remove expected data (#1783)#1790
flowbehappy merged 1 commit intopingcap:release-5.0from
ti-srebot:release-5.0-c72c331726b4

Conversation

@ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Apr 16, 2021

cherry-pick #1783 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/1790

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/1790:release-5.0-c72c331726b4

What problem does this PR solve?

Problem Summary:

Currently in DT engine, we only do place index for relevant query ranges in a segment. It can speed up individual region read, but the result of place index can not be shared between other region reads. It will eventually slow down the whole query processing if we have lots of cop requests.

What is changed and how it works?

What's Changed:

  1. This PR adds a new option dt_enable_relevant_place, and by default set to true, means enabling relevant place. The behavior is the same as the previous, but we can use the option to disable the relevant place.
  2. Fix bug: delete range can not remove expected data

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

  • Fix a potential issue that the DeleteRange in the storage engine failed to remove some data.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. labels Apr 16, 2021
@ti-srebot ti-srebot requested a review from JaySon-Huang April 16, 2021 08:44
@ti-srebot ti-srebot added this to the v5.0.1 milestone Apr 16, 2021
@flowbehappy
Copy link
Contributor

/run-all-tests

1 similar comment
@flowbehappy
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaySon-Huang
Copy link
Contributor

/rebuild

@flowbehappy flowbehappy merged commit f717fbe into pingcap:release-5.0 Apr 16, 2021
@flowbehappy flowbehappy deleted the release-5.0-c72c331726b4 branch April 16, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants