Delete range can not remove expected data (#1783)#1789
Merged
flowbehappy merged 2 commits intopingcap:release-4.0from Apr 16, 2021
Merged
Delete range can not remove expected data (#1783)#1789flowbehappy merged 2 commits intopingcap:release-4.0from
flowbehappy merged 2 commits intopingcap:release-4.0from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Contributor
|
/run-all-tests |
Contributor
|
/build |
Contributor
|
/run-all-tests |
c32c308 to
c9ec694
Compare
Contributor
|
/run-all-tests |
Member
|
@ti-srebot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #1783 to release-4.0
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/1789After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary:
Currently in DT engine, we only do place index for relevant query ranges in a segment. It can speed up individual region read, but the result of place index can not be shared between other region reads. It will eventually slow down the whole query processing if we have lots of cop requests.
Some data failed to be removed after region peer migrated to other nodes.
What is changed and how it works?
What's Changed:
dt_enable_relevant_place, and by default set totrue, means enabling relevant place. The behavior is the same as the previous, but we can use the option to disable the relevant place.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note