Skip to content

MPP: add CancelMPPTask for FlashService#1505

Merged
fzhedu merged 7 commits intopingcap:masterfrom
fzhedu:calcelMppTask
Mar 12, 2021
Merged

MPP: add CancelMPPTask for FlashService#1505
fzhedu merged 7 commits intopingcap:masterfrom
fzhedu:calcelMppTask

Conversation

@fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Mar 1, 2021

What problem does this PR solve?

Issue Number: close #1443

Problem Summary: cancel running mpp tasks from mysql client.

What is changed and how it works?

Proposal: pingcap/tidb#23056

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • Cancel mpp tasks from mysql client

@windtalker
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 3, 2021
Copy link
Contributor

@leiysky leiysky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 8, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 8, 2021
@leiysky
Copy link
Contributor

leiysky commented Mar 8, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 8, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@fzhedu merge failed.

@fzhedu
Copy link
Contributor Author

fzhedu commented Mar 12, 2021

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

1 similar comment
@fzhedu
Copy link
Contributor Author

fzhedu commented Mar 12, 2021

/run-all-tests

@ti-srebot
Copy link
Collaborator

@fzhedu merge failed.

@fzhedu
Copy link
Contributor Author

fzhedu commented Mar 12, 2021

/run-all-tests

@fzhedu fzhedu merged commit dee8374 into pingcap:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need a mechanism to kill long-hang queries

4 participants