Skip to content

Support extract datetime scalar function#1406

Merged
ti-srebot merged 12 commits intopingcap:masterfrom
leiysky:feature/extract-datetime
Feb 5, 2021
Merged

Support extract datetime scalar function#1406
ti-srebot merged 12 commits intopingcap:masterfrom
leiysky:feature/extract-datetime

Conversation

@leiysky
Copy link
Contributor

@leiysky leiysky commented Jan 29, 2021

What problem does this PR solve?

Issue Number: close #1401

Problem Summary:

What is changed and how it works?

What's Changed:

  • Add function FunctionExtractMyDateTime

How it Works:

Related changes

Check List

Tests

  • Unit test

Release note

  • Support push down EXTRACT function for data type DATETIME to TiFlash

@leiysky
Copy link
Contributor Author

leiysky commented Jan 29, 2021

/run-all-tests

@leiysky
Copy link
Contributor Author

leiysky commented Feb 1, 2021

/run-all-tests

@leiysky
Copy link
Contributor Author

leiysky commented Feb 1, 2021

/run-all-tests

@leiysky
Copy link
Contributor Author

leiysky commented Feb 1, 2021

@windtalker PTAL

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 1, 2021
@leiysky leiysky added the status/can-merge Indicates a PR has been approved by a committer. label Feb 1, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@leiysky merge failed.

@tisonkun
Copy link
Contributor

tisonkun commented Feb 1, 2021

it seems test ran before build completed, how can we check Jenkins config? I found we have a Jenkins file which left empty and said configuration all set via web interface.

@leiysky
Copy link
Contributor Author

leiysky commented Feb 4, 2021

/run-all-tests

@leiysky
Copy link
Contributor Author

leiysky commented Feb 4, 2021

it seems test ran before build completed, how can we check Jenkins config? I found we have a Jenkins file which left empty and said configuration all set via web interface.

Sorry for the late reply. CI/test will keep polling status of build stage until speficified image is built. This failure seems to be a little bug.

@leiysky
Copy link
Contributor Author

leiysky commented Feb 4, 2021

/run-all-tests

1 similar comment
@leiysky
Copy link
Contributor Author

leiysky commented Feb 5, 2021

/run-all-tests

@leiysky
Copy link
Contributor Author

leiysky commented Feb 5, 2021

/run-all-tests

1 similar comment
@leiysky
Copy link
Contributor Author

leiysky commented Feb 5, 2021

/run-all-tests

@leiysky
Copy link
Contributor Author

leiysky commented Feb 5, 2021

/merge

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 54d90b7 into pingcap:master Feb 5, 2021
@JaySon-Huang JaySon-Huang deleted the feature/extract-datetime branch February 6, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support EXTRACT datetime function push down

4 participants