optimize Date format (#1337)#1339
Merged
ti-srebot merged 10 commits intopingcap:release-4.0from Jan 20, 2021
Merged
Conversation
Contributor
|
LGTM |
Collaborator
Author
|
/run-all-tests |
Contributor
|
/merge |
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #1337 to release-4.0
What problem does this PR solve?
Problem Summary:
DateFormat is slow in TiFlash, need to optimize it.
What is changed and how it works?
What's Changed:
How it Works:
sprintfinMyTimeBase::dateFormatFunctionDateFormatResult:
on TPCH-20, with batchcop
select count(date_format(L_SHIPDATE, '%Y-%m-%d')) from lineitemRelated changes
Check List
Tests
Side effects
Release note