Fix broken files may be left on disk after TiFlash crash (#1143)#1155
Merged
JaySon-Huang merged 3 commits intopingcap:release-4.0from Oct 15, 2020
Merged
Conversation
* Fix the issue that process crash may leave some broken DMFiles Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Contributor
Author
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick of #1143
What problem does this PR solve?
Issue Number: close #1138
Problem Summary: There could be a chance that TiFlash crashes when a DMFile is being deleted. For a table with many columns or the disk is busy, the deletion may not be completed and left some broken DMFiles on disk. Those broken DMFiles make trouble for TiFlash to restart normally.
What is changed and how it works?
To remove a DMFile, rename its directory (under directory storage model) with a prefix first. Clean those DMFiles should be deleted when
DMFile::listAllInPathis called.Even if there are broken DMFiles left, we can safely clean them when
DMFile::listAllInPathis called.Related changes
Check List
Tests
Side effects
Release note