Revert "Support graceful shutdown in TiFlash"#10298
Revert "Support graceful shutdown in TiFlash"#10298ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Conversation
This reverts commit bec1390.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/test pull-integration-test |
|
In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tiflash#release-8.5 from head ti-chi-bot:cherry-pick-10298-to-release-8.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between pingcap:release-8.5 and ti-chi-bot:cherry-pick-10298-to-release-8.5"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} |
This reverts commit bec1390.
What problem does this PR solve?
Issue Number: ref #10266
Problem Summary:
#10267 does not support a real graceful shutdown because the read index request will be canceled if setting
stoppingto store status, which is not expected and can cause MPP tasks to fail.What is changed and how it works?
To make the upcoming cherry-pick easier, this PR reverts #10267 first.
Then I will file a new PR to fix this issue.
Check List
Tests
Side effects
Documentation
Release note