Skip to content

IO: Enhance rate limiter tests for write only#10244

Merged
ti-chi-bot[bot] merged 8 commits intopingcap:masterfrom
JaySon-Huang:enhance_rate_limiter
Jun 17, 2025
Merged

IO: Enhance rate limiter tests for write only#10244
ti-chi-bot[bot] merged 8 commits intopingcap:masterfrom
JaySon-Huang:enhance_rate_limiter

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Jun 16, 2025

What problem does this PR solve?

Issue Number: close #10247

Problem Summary:
The actual throughput limit about fg_write/bg_write/fg_read/bg_read will be tuned by the auto tune strategy in IORateLimiter. Add metrics about the actual throughput could help us better understand and diagnostics rate limiter related issues.

What is changed and how it works?

* Add a new metrics `tiflash_storage_io_limiter_curr` and a panel "IO Limiter Threshold" to show the current threshold of different kinds of threshold
* Add a row group "Rate Limiter" on the TiFlash-Summary Grafana
* Enhance some tests about rate limiter only set the limiter on write
* Refine some logging struct of rate limiter

The screenshot of

  • Add a row group "Rate Limiter" on the TiFlash-Summary Grafana
  • IO Limiter Threshold, we can check how the auto tune logic change the limit threshold of fg_write/bg_write/fg_read/bg_read
    image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Add more metrics about rate limiter

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 16, 2025
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang JaySon-Huang force-pushed the enhance_rate_limiter branch from ac232cc to 9d30ce7 Compare June 17, 2025 03:00
@JaySon-Huang
Copy link
Contributor Author

/test all

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 17, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-17 04:15:36.300738345 +0000 UTC m=+158789.023917326: ☑️ agreed by Lloyd-Pottiger.
  • 2025-06-17 04:16:22.393167493 +0000 UTC m=+158835.116346475: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot merged commit 30e444f into pingcap:master Jun 17, 2025
7 checks passed
@JaySon-Huang JaySon-Huang deleted the enhance_rate_limiter branch June 17, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add metrics about IORateLimter auto tune result

3 participants