Raft: Backport FAP enhancement#10208
Merged
ti-chi-bot[bot] merged 7 commits intopingcap:masterfrom May 29, 2025
Merged
Conversation
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com> Co-authored-by: JaySon <tshent@qq.com>
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com> Signed-off-by: JaySon-Huang <tshent@qq.com> Co-authored-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
commented
May 27, 2025
Comment on lines
+71
to
+75
| #if ENABLE_NEXT_GEN | ||
| , fap_use_segment_to_end_map_cache(settings.fap_use_segment_to_end_map_cache) | ||
| #else | ||
| , fap_use_segment_to_end_map_cache(true) | ||
| #endif |
Contributor
Author
There was a problem hiding this comment.
@CalvinNeo PTAL, can we remove the settings.fap_use_segment_to_end_map_cache and skip the segment_to_end_map_cache by default?
Member
There was a problem hiding this comment.
Yes, skip it is fine. We can switch to https://github.com/tidbcloud/tiflash-cse/pull/387
Signed-off-by: JaySon-Huang <tshent@qq.com>
Member
|
/retest |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Lloyd-Pottiger
approved these changes
May 29, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #8673
Problem Summary: Backport FAP enhancement
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note