Skip to content

tests: add fullstack test for inverted index#10076

Merged
ti-chi-bot[bot] merged 9 commits intopingcap:masterfrom
Lloyd-Pottiger:add-inverted-index-ft
Apr 16, 2025
Merged

tests: add fullstack test for inverted index#10076
ti-chi-bot[bot] merged 9 commits intopingcap:masterfrom
Lloyd-Pottiger:add-inverted-index-ft

Conversation

@Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Apr 2, 2025 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #9843

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@Lloyd-Pottiger
tests: add fullstack test for inverted index
840bdd4 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2025
@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Apr 2, 2025

/hold

pingcap/tidb#59571 should merge first.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2025
@Lloyd-Pottiger
more
bf09c06 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
JaySon-Huang
JaySon-Huang reviewed Apr 2, 2025
View reviewed changes
@Lloyd-Pottiger
address comments
f266eca 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2025
@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Apr 14, 2025

/retest

JaySon-Huang and others added 3 commits April 14, 2025 10:33
@JaySon-Huang
Update case
609ddb3 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Update case
c144477 
Signed-off-by: JaySon-Huang <tshent@qq.com>
@Lloyd-Pottiger
Merge branch 'master' into add-inverted-index-ft
8165580
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 15, 2025
JaySon-Huang
JaySon-Huang approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breezewish, JaySon-Huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,breezewish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 15, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-15 11:39:34.199224317 +0000 UTC m=+2774867.883460422: ☑️ agreed by breezewish.
  • 2025-04-15 13:15:12.915379176 +0000 UTC m=+2780606.599615257: ☑️ agreed by JaySon-Huang.

@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Apr 15, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2025
@breezewish
Copy link
Member

breezewish commented Apr 15, 2025

/retest

1 similar comment
@Lloyd-Pottiger
Copy link
Contributor Author

Lloyd-Pottiger commented Apr 16, 2025

/retest

@ti-chi-bot ti-chi-bot bot merged commit cdbc351 into pingcap:master Apr 16, 2025
5 checks passed
@Lloyd-Pottiger Lloyd-Pottiger deleted the add-inverted-index-ft branch April 16, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breezewish breezewish breezewish approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

No one assigned

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Inverted Index on Single Numerical Column

3 participants

@Lloyd-Pottiger @JaySon-Huang @breezewish