KVStore: Fix fail to restore tikv value larger than 16MiB (#10055)#10068
Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.1from Apr 2, 2025
Merged
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
12 tasks
Member
Author
|
@JaySon-Huang This PR has conflicts, I have hold it. |
JaySon-Huang
reviewed
Apr 1, 2025
Signed-off-by: JaySon-Huang <tshent@qq.com>
b40c4f8 to
25c648d
Compare
JaySon-Huang
approved these changes
Apr 2, 2025
Lloyd-Pottiger
approved these changes
Apr 2, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #10055
What problem does this PR solve?
Issue Number: close #10052
Problem Summary:
TiDB could allow a raft-log with 120MiB at max, while TiFlash
Region::deserializeusereadBinary2<std::string>only allow 16MiB at max. So if there are some raftlog larger than 16MiB and flushed toRegionData, then TiFlash could fail to restart when restoring Region data from disk.If the raftlog is committed, the rows are decoded into
Blockand write down toIStorage. Reading/writing rows larger than16MiBin theIStoragelayer does not cause any error.What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note