Skip to content

cherry pick #9736 to release-8.5#10059

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
windtalker:release-8.5
Apr 7, 2025
Merged

cherry pick #9736 to release-8.5#10059
ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
windtalker:release-8.5

Conversation

@windtalker
Copy link
Contributor

@windtalker windtalker commented Mar 31, 2025 •
edited
Loading

ExchangeSenderOp check writer status only if there is data to flush to MPPTunnel (#9736)

What problem does this PR solve?

Issue Number: close #10058

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@windtalker
ExchangeSenderOp check writer status only if there is data to flush t…
33c5322 
…o MPPTunnel (pingcap#9736)

ref pingcap#6233

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 31, 2025
yibin87
yibin87 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 1, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, yibin87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 1, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-01 06:20:32.218626484 +0000 UTC m=+1546125.902862578: ☑️ agreed by yibin87.
  • 2025-04-01 06:24:02.305030762 +0000 UTC m=+1546335.989266857: ☑️ agreed by gengliqi.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 3, 2025
@windtalker
Copy link
Contributor Author

windtalker commented Apr 4, 2025

/run-all-tests

@windtalker
Copy link
Contributor Author

windtalker commented Apr 7, 2025

/test all

@ti-chi-bot ti-chi-bot bot merged commit 4e59807 into pingcap:release-8.5 Apr 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yibin87 yibin87 yibin87 approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees

No one assigned

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@windtalker @yibin87 @gengliqi