-
Notifications
You must be signed in to change notification settings - Fork 409
Closed
Labels
type/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.
Description
Enhancement
RUNTIME_CHECK
Current RUNTIME_CHECK usage is:
RUNTIME_CHECK(a != b, ExceptionType, "{} != {}", a, b);
It's not clear for users to know which exception will be thrown. A better way is to explicit write code for generating an exception object like:
RUNTIME_CHECK(a != b, ExceptionType("{} != {}", a, b));
And the new style could enable better compilation checks.
RUNTIME_ASSERT
Current RUNTIME_ASSERT always needs a logger and make it hard for replacing existent asserts. We should let it work without user provided logger (in which case a default logger is used).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type/enhancementThe issue or PR belongs to an enhancement.The issue or PR belongs to an enhancement.