-
Notifications
You must be signed in to change notification settings - Fork 411
Closed
Labels
Description
Currently, MarkCache and MinMaxIndexCache use LRUCache to manage the mapping. We hash the file path into UInt128, so that it is easy to use an unordered_map. Although it is efficient, the hash algorithm can still have chances of conflicts. i.e. two different paths share the same hash_code. We cannot tolerate the conflict, because it will cause data error or exceptions.
Instead of relying on hash code, we can use std::map<Path, Value>. In sacrificing some efficiency, we gain correctness.
Reactions are currently unavailable