Skip to content

group_concat with spill may crash #10553

@ChangRui-Ryan

Description

@ChangRui-Ryan

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Use tpch 10g data and SET TIFLASH REPLICA for two tables below.

mysql> set sql_mode = 'ONLY_FULL_GROUP_BY,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION';
Query OK, 0 rows affected (0.00 sec)
mysql> set tidb_enforce_mpp=on;set session tidb_max_tiflash_threads = 4;
Query OK, 0 rows affected (0.00 sec)
Query OK, 0 rows affected (0.00 sec)
mysql> set tiflash_query_spill_ratio=0.01;
Query OK, 0 rows affected (0.00 sec)
mysql> set tiflash_mem_quota_query_per_node=1000000000;
Query OK, 0 rows affected (0.00 sec)
mysql> SELECT
        o_custkey AS customer_id,
        o_orderpriority AS day_part,
        o_orderstatus AS be_type,
        l_partkey AS product_code,
        GROUP_CONCAT(DISTINCT l_shipmode) AS store_code,
        MAX(order_time) AS last_order_time,
        MAX(order_id) AS last_order_id
    FROM (
        SELECT
            o_custkey,
            o_orderpriority,
            o_orderstatus,
            l_partkey,
            l_shipmode,
            l_orderkey AS order_id,
            o_orderdate AS order_time
        FROM lineitem
        LEFT JOIN orders ON l_orderkey = o_orderkey
    ) order_detail
    GROUP BY customer_id, day_part, be_type, product_code;

2. What did you expect to see? (Required)

query success.

3. What did you see instead (Required)

query failed and tiflash crash

4. What is your TiFlash version? (Required)

nightly

Metadata

Metadata

Assignees

No one assigned

    Labels

    affects-7.1This bug affects the 7.1.x(LTS) versions.affects-7.5This bug affects the 7.5.x(LTS) versions.affects-8.1This bug affects the 8.1.x(LTS) versions.affects-8.5This bug affects the 8.5.x(LTS) versions.component/computeimpact/crashcrash/fatalreport/customerCustomers have encountered this bug.severity/majortype/bugThe issue is confirmed as a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions