feat(client): support ignore diff annotation#6631
Merged
ti-chi-bot[bot] merged 2 commits intopingcap:mainfrom Dec 26, 2025
Merged
feat(client): support ignore diff annotation#6631ti-chi-bot[bot] merged 2 commits intopingcap:mainfrom
ti-chi-bot[bot] merged 2 commits intopingcap:mainfrom
Conversation
Signed-off-by: liubo02 <liubo02@pingcap.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6631 +/- ##
==========================================
+ Coverage 39.26% 39.29% +0.03%
==========================================
Files 351 351
Lines 20680 20692 +12
==========================================
+ Hits 8119 8130 +11
- Misses 12561 12562 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Signed-off-by: liubo02 <liubo02@pingcap.com>
srstack
approved these changes
Dec 26, 2025
Contributor
[LGTM Timeline notifier]Timeline:
|
fgksgf
approved these changes
Dec 26, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fgksgf, srstack, tennix The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/test pull-e2e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pingcap.com/ignore-diffto avoid unexpected diff produced by mutating webhook.Why
Local dns webhook of aliyun will change
spec.dnsPolicytoNonewhen pod is creating.And the webhook doesn't handle the
UPDATEoperation. It breaks the apply op if we setspec.hostNetwork: trueandspec.dnsPolicy: ClusterFirstWithHostNet.And we cannot unset the
spec.dnsPolicybecause the webhook depends on this field to inject the dns config.We cannot ensure that all mutating webhooks work properly and it's also hard to filter all immutable fields in client side. That's why we add this annotation to ignore diff.
How to use