feat(tikvworker): support tikv worker#6621
Conversation
Signed-off-by: liubo02 <liubo02@pingcap.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6621 +/- ##
==========================================
- Coverage 40.98% 39.53% -1.46%
==========================================
Files 343 351 +8
Lines 20010 20659 +649
==========================================
- Hits 8201 8167 -34
- Misses 11809 12492 +683
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive support for the TiKV Worker component to the tidb-operator. TiKV Worker is a new component type that follows a similar architecture pattern to existing components like TiProxy and TSO.
Key Changes
- Introduces new CRD types for TiKVWorker and TiKVWorkerGroup with full controller implementations
- Adds e2e test infrastructure including waiters, actions, and test data generators
- Refactors common utility functions (HeadlessServiceName, PersistentVolumeClaimName) to be generic across all component types
Reviewed changes
Copilot reviewed 103 out of 105 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| api/core/v1alpha1/tikv_worker_types.go | Defines TiKVWorker and TiKVWorkerGroup CRD types with specs and statuses |
| pkg/controllers/tikvworker/ | Implements instance-level controller for TiKVWorker |
| pkg/controllers/tikvworkergroup/ | Implements group-level controller for TiKVWorkerGroup |
| pkg/runtime/zz_generated.runtime.tikvworker.go | Generated runtime wrappers for TiKVWorker types |
| pkg/configs/tikvworker/config.go | Configuration management for TiKVWorker |
| tests/e2e/ | Test infrastructure additions for TiKVWorker |
| pkg/apiutil/core/v1alpha1/ | Refactored utility functions to use generics |
| cmd/tidb-operator/main.go | Registers TiKVWorker controllers and indexers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fgksgf The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: liubo02 <liubo02@pingcap.com>
Uh oh!
There was an error while loading. Please reload this page.