Skip to content

refactor(finalizer): combine instance finalizer task#6619

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:mainfrom
liubog2008:liubo02/extract-finalizer
Dec 22, 2025
Merged

refactor(finalizer): combine instance finalizer task#6619
ti-chi-bot[bot] merged 3 commits intopingcap:mainfrom
liubog2008:liubo02/extract-finalizer

Conversation

@liubog2008
Copy link
Member

@liubog2008 liubog2008 commented Dec 19, 2025

  • Extract finalizer del task to common

@github-actions github-actions bot added the v2 for operator v2 label Dec 19, 2025
@ti-chi-bot ti-chi-bot bot added the size/XXL label Dec 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.98%. Comparing base (b52d94a) to head (0db2eb4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6619      +/-   ##
==========================================
- Coverage   41.21%   40.98%   -0.23%     
==========================================
  Files         350      343       -7     
  Lines       20174    20010     -164     
==========================================
- Hits         8314     8201     -113     
+ Misses      11860    11809      -51     
Flag Coverage Δ
unittest 40.98% <50.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: liubo02 <liubo02@pingcap.com>
Signed-off-by: liubo02 <liubo02@pingcap.com>
@liubog2008 liubog2008 force-pushed the liubo02/extract-finalizer branch from 484a765 to a52f95b Compare December 19, 2025 09:10
@liubog2008
Copy link
Member Author

/test pull-e2e

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-22 03:35:57.691876165 +0000 UTC m=+2048902.505653737: ☑️ agreed by csuzhangxc.

Signed-off-by: liubo02 <liubo02@pingcap.com>
@ti-chi-bot ti-chi-bot bot merged commit 7f8dc94 into pingcap:main Dec 22, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants