Skip to content

fix(tidb): unexpectedly use secret for sem config#6573

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:mainfrom
liubog2008:liubo02/fix-sem
Dec 5, 2025
Merged

fix(tidb): unexpectedly use secret for sem config#6573
ti-chi-bot[bot] merged 1 commit intopingcap:mainfrom
liubog2008:liubo02/fix-sem

Conversation

@liubog2008
Copy link
Member

@liubog2008 liubog2008 commented Dec 5, 2025

  • unexpectedly use secret for sem config, change back to configmap

Signed-off-by: liubo02 <liubo02@pingcap.com>
@ti-chi-bot ti-chi-bot bot requested review from howardlau1999 and shonge December 5, 2025 03:38
@github-actions github-actions bot added the v2 for operator v2 label Dec 5, 2025
@ti-chi-bot ti-chi-bot bot added the size/L label Dec 5, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 5, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-05 03:39:39.608100635 +0000 UTC m=+580324.421878207: ☑️ agreed by srstack.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 5, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.36%. Comparing base (40798d3) to head (ed05c5a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6573      +/-   ##
==========================================
- Coverage   41.36%   41.36%   -0.01%     
==========================================
  Files         348      348              
  Lines       19872    19875       +3     
==========================================
  Hits         8221     8221              
- Misses      11651    11654       +3     
Flag Coverage Δ
unittest 41.36% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fgksgf, srstack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liubog2008
Copy link
Member Author

/test pull-e2e

2 similar comments
@liubog2008
Copy link
Member Author

/test pull-e2e

@liubog2008
Copy link
Member Author

/test pull-e2e

@ti-chi-bot ti-chi-bot bot merged commit 3546f37 into pingcap:main Dec 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants