Conversation
|
I see this shelling out to run br but I expected br to be ran as a job. I thought br could take a very long time to complete. |
This PR reuses the backup-manager introduced in the current backup feature with mydumper, it is run in a job and backup-manager will call br to backup data. |
|
/run-e2e-in-kind |
|
Code updated due to BR cli options change in pingcap/br#103.
|
5d3295a to
d9f91c4
Compare
| @@ -14,200 +14,128 @@ | |||
| package backup | |||
There was a problem hiding this comment.
This is the backup file for BR.
| @@ -14,43 +14,38 @@ | |||
| package backup | |||
There was a problem hiding this comment.
This is the backup manager for BR.
| @@ -0,0 +1,79 @@ | |||
| // Copyright 2019 PingCAP, Inc. | |||
There was a problem hiding this comment.
This is renamed from cmd/backup-manager/app/cmd/backup.go.
| @@ -0,0 +1,203 @@ | |||
| // Copyright 2019 PingCAP, Inc. | |||
There was a problem hiding this comment.
This is renamed from cmd/backup-manager/app/backup/backup.go.
| @@ -0,0 +1,239 @@ | |||
| // Copyright 2019 PingCAP, Inc. | |||
There was a problem hiding this comment.
This is renamed from cmd/backup-manager/app/backup/manager.go.
|
@tennix @onlymellb @shuijing198799 @gregwebs PTAL the new commits to line up with the latest BR update. |
|
Update scheduled backup with BR, PTAL. |
|
@onlymellb comments addressed, PTAL. |
What problem does this PR solve?
backup to S3 with br for issue #1249
What is changed and how does it work?
Support new BR for backup to S3
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: